Add clustered migration sync for shared disks (SYNCING barrier)#403
Open
fabi200123 wants to merge 1 commit into
Open
Add clustered migration sync for shared disks (SYNCING barrier)#403fabi200123 wants to merge 1 commit into
fabi200123 wants to merge 1 commit into
Conversation
Dany9966
requested changes
Apr 1, 2026
fabi200123
force-pushed
the
cor-707
branch
4 times, most recently
from
9813d2b to
61ebc94
Compare
Dany9966
reviewed
Apr 15, 2026
fabi200123
force-pushed
the
cor-707
branch
3 times, most recently
from
173c46b to
6433f4e
Compare
Dany9966
requested changes
Jun 23, 2026
fabi200123
force-pushed
the
cor-707
branch
2 times, most recently
from
6e211ad to
f1476b1
Compare
Dany9966
approved these changes
Jul 2, 2026
| for disk_id in shared_disk_ids: | ||
| ident = utils.cluster_disk_identity(disk_id) | ||
| owner_id = owners.get(ident) | ||
| if owner_id == instance_id or not owner_id: |
Contributor
There was a problem hiding this comment.
Shouldn't it be guaranteed that we get an owner_id? I feel like this should error out if there's no owner returned.
| target_vol = vol | ||
| break | ||
| if target_vol is None: | ||
| norm_wid = utils.cluster_disk_identity( |
Contributor
There was a problem hiding this comment.
Why not use ident instead of assigning a new norm_wid? It's the same value.
| if target_vol is None: | ||
| norm_wid = utils.cluster_disk_identity( | ||
| disk_id) | ||
| for vol in volumes_info: |
Contributor
There was a problem hiding this comment.
This for loop is pointless. The same thing is already checked above (since ident == norm_wid).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds core support for the shared disks clustered transfers:
SYNCINGtask status and aTASK_TYPES_TO_SYNClist (GET_INSTANCE_INFO,SHUTDOWN_INSTANCE). (These tasks wait for their peers across all instances of a clustered transfer before completing)clusteredflag onBaseTransferAction, set automatically when a transfer has more than one instance.GET_INSTANCE_INFOtasks sync, the conductor assigns anowner(new property in the VM export info schema) to every disk in each instance'sexport_info(first instance reporting a disk id owns it).REPLICATE_DISKSnow passes the fullvolumes_infoto the source provider (skipping shared disks is handled provider-side).SYNCINGare failed too (cancellation handlesSYNCINGtasks like pending ones).